From d3a9e5b41d5c7ab02a9dc42156b1e9e451ed3a40 Mon Sep 17 00:00:00 2001 From: Alex Black Date: Sat, 22 Jun 2019 16:21:27 +1000 Subject: [PATCH] Update contributing and issue/PR templates (#7934) Signed-off-by: AlexDBlack --- .github/ISSUE_TEMPLATE.md | 9 ++++++++- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- CONTRIBUTING.md | 5 +++++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 95d46fee4..f89c0266d 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -9,10 +9,17 @@ Please describe our issue, along with: Please indicate relevant versions, including, if relevant: * Deeplearning4j version -* platform information (OS, etc) +* Platform information (OS, etc) * CUDA version, if used * NVIDIA driver version, if in use +#### Additional Information + +Where applicable, please also provide: + +* Full log or exception stack trace (ideally in a Gist: gist.github.com) +* pom.xml file or similar (also in a Gist) + #### Contributing If you'd like to help us fix the issue by contributing some code, but would diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 44316b06f..152464684 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,7 @@ The following checklist helps ensure your PR is complete: -- [ ] Reviewed the [Contributing Guidelines](https://github.com/deeplearning4j/deeplearning4j/blob/master/CONTRIBUTING.md) and followed the steps within. +- [ ] Eclipse Contributor Agreement signed, and signed commits - see [IP Requirements](https://deeplearning4j.org/eclipse-contributors) page for details +- [ ] Reviewed the [Contributing Guidelines](https://github.com/eclipse/deeplearning4j/blob/master/CONTRIBUTING.md) and followed the steps within. - [ ] Created tests for any significant new code additions. - [ ] Relevant tests for your changes are passing. -- [ ] Ran mvn formatter:format (see [formatter instructions](http://code.revelc.net/formatter-maven-plugin/examples.html#Setting_Source_Files) for targeting your specific files). diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b2394f73b..024ac9c21 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,3 +44,8 @@ main tree or given feedback for changes that would be required. We follow the [Rust Code of Conduct](http://www.rust-lang.org/conduct.html). All code in this repository is released under the Apache Software Foundation License, 2.0, and by contributing to this repository, you agree to release that contribution under that same license. + + +## Eclipse Contributor Agreement and Commit Signing + +Please see the following page for details: [https://deeplearning4j.org/eclipse-contributors](https://deeplearning4j.org/eclipse-contributors) \ No newline at end of file