From bb9cdb251e9a1d739e06ffd127370108b694e6ce Mon Sep 17 00:00:00 2001
From: Paul Dubs <paul.dubs@gmail.com>
Date: Fri, 17 Apr 2020 02:19:21 +0200
Subject: [PATCH] Small ConvolutionalIterationListener improvements (#382)

* Add a message to the runtime exception

Signed-off-by: Paul Dubs <paul.dubs@gmail.com>

* Output Convolutions as PNG instead of JPG

A lossless encoding is useful in this case, as it allows small details to be preserved

Signed-off-by: Paul Dubs <paul.dubs@gmail.com>
---
 .../ui/weights/ConvolutionalIterationListener.java        | 2 +-
 .../module/convolutional/ConvolutionalListenerModule.java | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-ui/src/main/java/org/deeplearning4j/ui/weights/ConvolutionalIterationListener.java b/deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-ui/src/main/java/org/deeplearning4j/ui/weights/ConvolutionalIterationListener.java
index 037c44b40..4aae630ca 100644
--- a/deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-ui/src/main/java/org/deeplearning4j/ui/weights/ConvolutionalIterationListener.java
+++ b/deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-ui/src/main/java/org/deeplearning4j/ui/weights/ConvolutionalIterationListener.java
@@ -140,7 +140,7 @@ public class ConvolutionalIterationListener extends BaseTrainingListener {
                 ComputationGraph l = (ComputationGraph) model;
                 Layer[] layers = l.getLayers();
                 if(layers.length != activations.size())
-                    throw new RuntimeException();
+                    throw new RuntimeException("layers.length != activations.size(). Got layers.length="+layers.length+", activations.size()="+activations.size());
                 for( int i=0; i<layers.length; i++ ){
                     if(layers[i].type() == Layer.Type.CONVOLUTIONAL){
                         String layerName = layers[i].conf().getLayer().getLayerName();
diff --git a/deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/java/org/deeplearning4j/ui/module/convolutional/ConvolutionalListenerModule.java b/deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/java/org/deeplearning4j/ui/module/convolutional/ConvolutionalListenerModule.java
index 0df50032f..3236e9b2f 100644
--- a/deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/java/org/deeplearning4j/ui/module/convolutional/ConvolutionalListenerModule.java
+++ b/deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/java/org/deeplearning4j/ui/module/convolutional/ConvolutionalListenerModule.java
@@ -105,22 +105,22 @@ public class ConvolutionalListenerModule implements UIModule {
                 BufferedImage bi = clp.getImg();
                 ByteArrayOutputStream baos = new ByteArrayOutputStream();
                 try {
-                    ImageIO.write(bi, "jpg", baos);
+                    ImageIO.write(bi, "png", baos);
                 } catch (IOException e) {
                     log.warn("Error displaying image", e);
                 }
 
                 rc.response()
-                        .putHeader("content-type", "image/jpg")
+                        .putHeader("content-type", "image/png")
                         .end(Buffer.buffer(baos.toByteArray()));
             } else {
                 rc.response()
-                        .putHeader("content-type", "image/jpg")
+                        .putHeader("content-type", "image/png")
                         .end(Buffer.buffer(new byte[0]));
             }
         } else {
             rc.response()
-                    .putHeader("content-type", "image/jpg")
+                    .putHeader("content-type", "image/png")
                     .end(Buffer.buffer(new byte[0]));
         }
     }